Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify the "ReaderHeadersReady" message-handler in the API #18977

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Simplify the "ReaderHeadersReady" message-handler in the API #18977

merged 1 commit into from
Oct 29, 2024

Conversation

Snuffleupagus
Copy link
Collaborator

@Snuffleupagus Snuffleupagus commented Oct 29, 2024 •
edited
Loading

We can convert the handler to an async function, which removes the need to create a temporary Promise here.
Given the age of this code it shouldn't hurt to simplify it a little bit.

@Snuffleupagus Snuffleupagus changed the title Simplify the "ReaderHeadersReady"-message handler in the API Simplify the "ReaderHeadersReady" message-handler in the API Oct 29, 2024
@Snuffleupagus
Copy link
Collaborator Author

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/5933ebe33fb69bd/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/5f1ff547d1b4486/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/5933ebe33fb69bd/output.txt

Total script time: 30.85 mins

  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 17
  different first/second rendering: 2

Image differences available at: http://54.241.84.105:8877/5933ebe33fb69bd/reftest-analyzer.html#web=eq.log

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/5f1ff547d1b4486/output.txt

Total script time: 50.61 mins

  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: Passed

calixteman
calixteman reviewed Oct 29, 2024
View reviewed changes
src/display/api.js Outdated Show resolved Hide resolved
calixteman
calixteman approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@Snuffleupagus
Simplify the "ReaderHeadersReady" message-handler in the API
afb4813 
We can convert the handler to an `async` function, which removes the need to create a temporary Promise here.
Given the age of this code it shouldn't hurt to simplify it a little bit.
@Snuffleupagus
Copy link
Collaborator Author

/botio unittest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_unittest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/1731069d28b286f/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_unittest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/bbcabf9c558aa47/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/1731069d28b286f/output.txt

Total script time: 2.54 mins

  • Unit Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/bbcabf9c558aa47/output.txt

Total script time: 7.58 mins

  • Unit Tests: Passed

@Snuffleupagus Snuffleupagus merged commit 9870099 into mozilla:master Oct 29, 2024
10 checks passed
@Snuffleupagus Snuffleupagus deleted the api-ReaderHeadersReady-simplify branch October 29, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calixteman calixteman calixteman approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Snuffleupagus @moz-tools-bot @calixteman