Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jpgjs performance improvements #4497

Merged
merged 2 commits into from
Mar 21, 2014
Merged

Conversation

yurydelendik
Copy link
Contributor

@yurydelendik
Copy link
Contributor Author

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_test from @yurydelendik received. Current queue size: 0

Live output at: http://107.21.233.14:8877/70a2718e55dba04/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @yurydelendik received. Current queue size: 0

Live output at: http://107.22.172.223:8877/e77f035db92eca5/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux)


Failed

Full output at http://107.21.233.14:8877/70a2718e55dba04/output.txt

Total script time: 25.10 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://107.21.233.14:8877/70a2718e55dba04/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

From: Bot.io (Windows)


Failed

Full output at http://107.22.172.223:8877/e77f035db92eca5/output.txt

Total script time: 36.20 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://107.22.172.223:8877/e77f035db92eca5/reftest-analyzer.html#web=eq.log

@bthorben
Copy link
Contributor

I'll have a look at it

@bthorben
Copy link
Contributor

I pushed another patch to jpgjs that "fixes" this problem

@yurydelendik
Copy link
Contributor Author

and notmasteryet/jpgjs#23

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_test from @yurydelendik received. Current queue size: 0

Live output at: http://107.21.233.14:8877/63626d5f167882d/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @yurydelendik received. Current queue size: 0

Live output at: http://107.22.172.223:8877/ab56a39d6f49371/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux)


Failed

Full output at http://107.21.233.14:8877/63626d5f167882d/output.txt

Total script time: 25.20 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://107.21.233.14:8877/63626d5f167882d/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

From: Bot.io (Windows)


Failed

Full output at http://107.22.172.223:8877/ab56a39d6f49371/output.txt

Total script time: 36.08 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://107.22.172.223:8877/ab56a39d6f49371/reftest-analyzer.html#web=eq.log

@yurydelendik
Copy link
Contributor Author

I don't see any visible by eye defects, looks like int32 cast during clamping affected stuff

@yurydelendik
Copy link
Contributor Author

Okay those are cmyk jpegs so something like c = 255 - clampTo8Bit(...); will be affected.

/botio makeref

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_makeref from @yurydelendik received. Current queue size: 0

Live output at: http://107.21.233.14:8877/8280095a8c222cf/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_makeref from @yurydelendik received. Current queue size: 0

Live output at: http://107.22.172.223:8877/2dc32eaf8d0d818/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/8280095a8c222cf/output.txt

Total script time: 25.24 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://107.22.172.223:8877/2dc32eaf8d0d818/output.txt

Total script time: 35.63 mins

  • Lint: Ignored
  • Make references: Passed
  • Check references: Passed

yurydelendik added a commit that referenced this pull request Mar 21, 2014
jpgjs performance improvements
@yurydelendik yurydelendik merged commit 026d58e into mozilla:master Mar 21, 2014
@yurydelendik yurydelendik deleted the jpgjs22 branch March 21, 2014 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants