Refactor - remove redundant function and all references #4614
Conversation
| @@ -14,7 +14,7 @@ | |||
| * See the License for the specific language governing permissions and | |||
| * limitations under the License. | |||
| */ | |||
| /* globals assert, assertWellFormed, ColorSpace, DecodeStream, Dict, Encodings, | |||
| /* globals assert, assert, ColorSpace, DecodeStream, Dict, Encodings, | |||
There was a problem hiding this comment.
assert is specified two times
The function `assertWllFormed` was doing nothing different than `assert` which is available in the same namespace. Removing it will lighten the filesize - albeit very slightly - and reduce complexity.
|
You're absolutely correct. Good spot. Sorry, I was a little too hasty in submitting. |
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.22.172.223:8877/c19e47bf6d27160/output.txt |
From: Bot.io (Linux)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/c7763c13bf804c8/output.txt |
From: Bot.io (Windows)FailedFull output at http://107.22.172.223:8877/c19e47bf6d27160/output.txt Total script time: 3.03 mins
Image differences available at: http://107.22.172.223:8877/c19e47bf6d27160/reftest-analyzer.html#web=eq.log |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/c7763c13bf804c8/output.txt Total script time: 25.60 mins
|
|
botio-windows is broken atm |
|
Looks good. Thanks |
Refactor - remove redundant function and all references
The function
assertWllFormedwas doing nothing different thanassertwhich isavailable in the same namespace. Removing it will lighten the filesize - albeit
very slightly - and reduce complexity.