Add support for setting multiple values at once in ViewHistory #4692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/botio-windows preview |
From: Bot.io (Windows)ReceivedCommand cmd_preview from @yurydelendik received. Current queue size: 0 Live output at: http://107.22.172.223:8877/3c09ed42b8c568e/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/3c09ed42b8c568e/output.txt Total script time: 0.30 mins Published
|
yurydelendik
added a commit
that referenced
this pull request
Apr 28, 2014
Add support for setting multiple values at once in ViewHistory
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently for every call to
updateViewarea,ViewHistory.setis called five times, which means that thedatabaseis converted to a string and written to storage five times in succession.This PR adds a method,
setMultiple, that sets all values before thedatabaseis written to storage.Generally the value of micro-benchmarks can be questioned, but to get at least some confirmation that this PR is meaningful I've tried comparing the current code with this patch: http://jsperf.com/viewhistory.
Based on the consistency of the results across various browsers, it seems probable that this PR does reduce the time taken to update the history.