Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate statcmp.py to JavaScript #4864

Merged
merged 1 commit into from
Jun 12, 2014

Conversation

fkaelberer
Copy link
Contributor

This PR translates statcmp.py to JavaScript (compare #4496).

The translation is close to 1:1, with the following minor exceptions:

  • Differences are displayed with opposite signs. -90ms and -90% now means that current is faster than baseline. Since all numbers are in ms, I thought that this shows lower is better more clearly. It also makes more obvious that it means 10x faster (compared to 1.9x faster).
  • If results are not grouped by 'stat', then only Overall results are used (page request and rendering are dropped). I thought it is more intuitive to show the Overall score in this case, rather than the average of Overall, rendering, and page request (which is 2/3 of Overall). As a side effect, the significance test delivers different results in this case.
  • The number of samples in each group is displayed (column Count).
  • The javascript ttest delivers slightly different results python's ttest, although differences are not big.

timvandermeij added a commit that referenced this pull request Jun 12, 2014
Translate statcmp.py to JavaScript
@timvandermeij timvandermeij merged commit 0ee6180 into mozilla:master Jun 12, 2014
@timvandermeij
Copy link
Contributor

Nice work, thank you!

@fkaelberer fkaelberer deleted the statcmp.js branch June 13, 2014 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants