Translate statcmp.py to JavaScript #4864
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR translates statcmp.py to JavaScript (compare #4496).
The translation is close to 1:1, with the following minor exceptions:
-90ms
and-90%
now means thatcurrent
is faster thanbaseline
. Since all numbers are in ms, I thought that this shows lower is better more clearly. It also makes more obvious that it means 10x faster (compared to 1.9x faster).Overall
results are used (page request
andrendering
are dropped). I thought it is more intuitive to show theOverall
score in this case, rather than the average ofOverall
,rendering
, andpage request
(which is 2/3 ofOverall
). As a side effect, the significance test delivers different results in this case.Count
).