Fix mishandling of incomplete, inverted masks. #4933
Conversation
|
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/4a5731e96c3b421/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/4a5731e96c3b421/output.txt Total script time: 0.72 mins Published
|
| } else { | ||
| data = new Uint8Array(computedLength); | ||
| data.set(imgArray); | ||
| for (var i = actualLength; i < computedLength; i++) { |
There was a problem hiding this comment.
To fix the lint error, please move var i to the top of the function (placed among the other variables) and remove it from R284 too.
Edit: Also, since the patch needs to be updated anyway: please reduce the indention of the next line by two spaces.
|
The updated patch fixes the lint error and the excess indentation. |
|
/botio test |
From: Bot.io (Linux)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/e6c40c5f6e44dcb/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.22.172.223:8877/d3fe21984cba9b5/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/d3fe21984cba9b5/output.txt Total script time: 20.72 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/e6c40c5f6e44dcb/output.txt Total script time: 24.66 mins
|
|
/botio makeref |
From: Bot.io (Linux)ReceivedCommand cmd_makeref from @yurydelendik received. Current queue size: 0 Live output at: http://107.21.233.14:8877/86dbdcd643b6670/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @yurydelendik received. Current queue size: 0 Live output at: http://107.22.172.223:8877/57d5dbac02c9b6e/output.txt |
|
looks good, thanks |
Fix mishandling of incomplete, inverted masks.
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/57d5dbac02c9b6e/output.txt Total script time: 20.93 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/86dbdcd643b6670/output.txt Total script time: 24.79 mins
|
This fixes #4926. Sometimes image masks have less data than the height*width requires. createMask() was handling this correctly on normal masks, but when the mask was inverted it did the wrong thing.