Implements onerror for JpegStreams #4969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
| @@ -1562,5 +1562,9 @@ function loadJpegStream(id, imageUrl, objs) { | |||
| img.onload = (function loadJpegStream_onloadClosure() { | |||
| objs.resolve(id, img); | |||
| }); | |||
| img.onerror = (function loadJpegStream_onerrorClosure() { | |||
| objs.resolve(id, null); | |||
| error('Image dependency not ready'); | |||
There was a problem hiding this comment.
make it a warning and change the text to something like 'Error during JPEG image loading'
There was a problem hiding this comment.
Done. This makes the console messages much nicer.
|
/botio test |
From: Bot.io (Linux)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 0 Live output at: http://107.21.233.14:8877/7133ca171ee0e71/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 0 Live output at: http://107.22.172.223:8877/e1d8942c5c999e7/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/e1d8942c5c999e7/output.txt Total script time: 21.36 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/7133ca171ee0e71/output.txt Total script time: 23.74 mins
|
|
Thanks |
yurydelendik
added a commit
that referenced
this pull request
Jun 18, 2014
Implements onerror for JpegStreams
This was referenced Jul 25, 2014
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partly addresses #2812. It resolves the infinite loop and renders everything but the images.
Thanks to @yurydelendik for helping with debugging this!