Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zero the height and width of the WebGL canvases on cleanup #5015

Merged
merged 1 commit into from
Jul 16, 2014
Merged

Zero the height and width of the WebGL canvases on cleanup #5015

merged 1 commit into from
Jul 16, 2014

Conversation

Snuffleupagus
Copy link
Collaborator

The same idea as PRs #4920 and #4959, but for the temporary canvases used in WebGL assisted rendering.

@CodingFabian
Copy link
Contributor

to assist reviewing: trivial, looks good to me

@timvandermeij
Copy link
Contributor

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/19b6c1392e8cc27/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://107.22.172.223:8877/b57f12b31a66ae7/output.txt

@Snuffleupagus
Copy link
Collaborator Author

I would be surprised if there are any test failures here, given that WebGL is off by default and hence isn't used on the test bots ;-)

@pdfjsbot
Copy link

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/19b6c1392e8cc27/output.txt

Total script time: 37.50 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@timvandermeij
Copy link
Contributor

@Snuffleupagus Me too, but I wouldn't want to risk merging this without having tested it first (I already tested it locally) :-)

But this is looking good, so it can be merged. Thank you for the patch!

timvandermeij added a commit that referenced this pull request Jul 16, 2014
Zero the height and width of the WebGL canvases on cleanup
@timvandermeij timvandermeij merged commit a7800c2 into mozilla:master Jul 16, 2014
@Snuffleupagus Snuffleupagus deleted the zero-WebGL-canvases branch July 16, 2014 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants