Removing unused code and enforcing additional JSHint options

[timvandermeij]

This PR consists of three commits.

• The first commit removes unused code (and fixes small code style issues).
• The second commit enforces JSHint's undef option and makes the necessary changes to make lint succeed.
• The third commit enforces JSHint's noarg and nonbsp options. No code changes were necessary for this, but it's good to enforce them to avoid having them appear in the codebase in the future.

[timvandermeij]

/botio-linux preview

[pdfjsbot]

From: Bot.io (Linux)

---

Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/27534178ce32ea7/output.txt

[pdfjsbot]

From: Bot.io (Linux)

---

Success

Full output at http://107.21.233.14:8877/27534178ce32ea7/output.txt

Total script time: 0.72 mins

Published

• Viewer: http://107.21.233.14:8877/27534178ce32ea7/web/viewer.html
• B2G Viewer: http://107.21.233.14:8877/27534178ce32ea7/extensions/b2g/content/web/viewer.html
• Extension: http://107.21.233.14:8877/27534178ce32ea7/extensions/firefox/pdf.js.xpi
• Extension (AMO): http://107.21.233.14:8877/27534178ce32ea7/extensions/firefox/pdf.js.amo.xpi

[timvandermeij]

/botio test

[pdfjsbot]

From: Bot.io (Linux)

---

Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/005f7088887d127/output.txt

[pdfjsbot]

From: Bot.io (Windows)

---

Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://107.22.172.223:8877/a5e095727a7a440/output.txt

[pdfjsbot]

From: Bot.io (Windows)

---

Success

Full output at http://107.22.172.223:8877/a5e095727a7a440/output.txt

Total script time: 21.15 mins

• Font tests: Passed
• Unit tests: Passed
• Regression tests: Passed

[pdfjsbot]

From: Bot.io (Linux)

---

Success

Full output at http://107.21.233.14:8877/005f7088887d127/output.txt

Total script time: 23.26 mins

• Font tests: Passed
• Unit tests: Passed
• Regression tests: Passed

[yurydelendik]

Looks good. I'll run test again though

/botio test

[pdfjsbot]

From: Bot.io (Windows)

---

Received

Command cmd_test from @yurydelendik received. Current queue size: 0

Live output at: http://107.22.172.223:8877/b92d1ae9a9f5f8a/output.txt

[pdfjsbot]

From: Bot.io (Linux)

---

Received

Command cmd_test from @yurydelendik received. Current queue size: 0

Live output at: http://107.21.233.14:8877/3f057616a78c286/output.txt

[pdfjsbot]

From: Bot.io (Windows)

---

Success

Full output at http://107.22.172.223:8877/b92d1ae9a9f5f8a/output.txt

Total script time: 21.23 mins

• Font tests: Passed
• Unit tests: Passed
• Regression tests: Passed

[yurydelendik]

/botio-windows lint

[pdfjsbot]

From: Bot.io (Windows)

---

Received

Command cmd_lint from @yurydelendik received. Current queue size: 0

Live output at: http://107.22.172.223:8877/386493daa8523c6/output.txt

[pdfjsbot]

From: Bot.io (Windows)

---

Success

Full output at http://107.22.172.223:8877/386493daa8523c6/output.txt

Total script time: 0.94 mins

• Lint: Passed

[pdfjsbot]

From: Bot.io (Linux)

---

Success

Full output at http://107.21.233.14:8877/3f057616a78c286/output.txt

Total script time: 23.38 mins

• Font tests: Passed
• Unit tests: Passed
• Regression tests: Passed

[yurydelendik]

Thank you