Stop including cidmaps.js #5088
Conversation
|
If the file is not used, delete it. If it is ever needed again, then it can be recovered from version control. |
|
I agree with Rob. Keeping the file would clutter the codebase, and being able to recover files if necessary is why Git is used in the first place :) |
In b5b94a4, i.e. PR #4259, we stopped using cidmaps.js. Despite that, it's still included when PDF.js is built. At almost 0.5 MB (and approx. 7000 lines), this is currently the single largest file in the codebase. Including such a large file in the builds, when it is not actually used, seems extremely wasteful; hence this patch.
|
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/02d5e40eeacd62a/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/02d5e40eeacd62a/output.txt Total script time: 0.77 mins Published
|
|
/botio test |
From: Bot.io (Linux)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/f0a6d18935ba89b/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://107.22.172.223:8877/0e20d7be503ac58/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/0e20d7be503ac58/output.txt Total script time: 21.18 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/f0a6d18935ba89b/output.txt Total script time: 22.88 mins
|
|
Looks good to me. I'll leave the final check for @yurydelendik. |
|
Looks good. Thanks. |
Stop including cidmaps.js
In b5b94a4, i.e. PR #4259, we stopped using cidmaps.js. Despite that, it's still included when PDF.js is built. At almost 0.5 MB (and approx. 7000 lines), this is currently the single largest file in the codebase.
Including such a large file in the builds, when it is not actually used, seems extremely wasteful; hence this patch.