Re-run feature detection after downgrading the Chromium browser. #5090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a user downgrades from Chromium 35+ to 34, then the PDF Viewer extension will not work any more because the extension assumes that certain features were available based on the cached feature detection results. To resolve this problem, all feature detection scripts run again if the browser was downgraded.
|
Looks good, thanks! |
timvandermeij
added a commit
that referenced
this pull request
Jul 30, 2014
Re-run feature detection after downgrading the Chromium browser.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a user downgrades from Chromium 35+ to 34, then the PDF Viewer extension will not work any more because the extension assumes that certain features were available based on the cached feature detection results.
To resolve this problem, all feature detection tests run again if the browser was downgraded.