Always check all Kids nodes, in Catalog.getPageDict, to avoid getting stuck in an empty node further down in the Pages tree (issue 8088)
#8105
Conversation
…ng stuck in an empty node further down in the Pages tree (issue 8088) As discussed on IRC, we need to check all nodes at the *bottom* of the tree to ensure that we find the correct `Page` dict. Furthermore, this patch also gets rid of the caching present in a previous version, since it's not clear if that really helps. Note that this patch purposely adds an `eq` test, using a reduced test-case, so that we can be sure that the algorithm actually finds the correct `Page` dict for each `pageIndex`. Fixes 8088.
|
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/1bc1a3890eedfff/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/1bc1a3890eedfff/output.txt Total script time: 2.10 mins Published |
|
/botio test |
From: Bot.io (Linux)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/f43ea97da6cbf11/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/1c09bb828f05cde/output.txt |
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/1c09bb828f05cde/output.txt Total script time: 21.54 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/f43ea97da6cbf11/output.txt Total script time: 25.40 mins
|
|
/botio makeref |
From: Bot.io (Linux)ReceivedCommand cmd_makeref from @brendandahl received. Current queue size: 0 Live output at: http://107.21.233.14:8877/c779a9dc735c318/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @brendandahl received. Current queue size: 0 Live output at: http://54.215.176.217:8877/a41b7f791885040/output.txt |
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/a41b7f791885040/output.txt Total script time: 21.17 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/c779a9dc735c318/output.txt Total script time: 25.69 mins
|
|
Thank you! |
Always check all Kids nodes, in `Catalog.getPageDict`, to avoid getting stuck in an empty node further down in the Pages tree (issue 8088)
As discussed on IRC, we need to check all nodes at the bottom of the tree to ensure that we find the correct
Pagedict.Furthermore, this patch also gets rid of the caching present in a previous version, since it's not clear if that really helps.
Note that this patch purposely adds an
eqtest, using a reduced test-case, so that we can be sure that the algorithm actually finds the correctPagedict for eachpageIndex.Fixes #8088.