Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add scrolling and spread modes to web viewer #9208

Merged
merged 6 commits into from
May 15, 2018
Merged

Add scrolling and spread modes to web viewer #9208

merged 6 commits into from
May 15, 2018
+985 −128

Commits on May 15, 2018

  1. Fix bug in scrollIntoView 

    Prior to this commit, if the vertical scroll bar is absent and the horizontal
scroll bar is present, a link to a particular point on the page which should
induce a horizontal scroll did not do so, because the absence of a vertical
scroll bar meant that the viewer was not recognized as the nearest scrolling
ancestor. This commit adds a check for horizontal scroll bars when searching
for the scrolling ancestor.
    @rhendric
    rhendric committed May 15, 2018
    Configuration menu
    Copy the full SHA
    65c8549 View commit details
    Browse the repository at this point in the history

  2. Add scrolling modes to web viewer 

    In addition to the default scrolling mode (vertical), this commit adds
horizontal and wrapped scrolling, implemented primarily with CSS.
    @rhendric
    rhendric committed May 15, 2018
    Configuration menu
    Copy the full SHA
    91cbc18 View commit details
    Browse the repository at this point in the history

  3. Add spread modes to web viewer 

    This builds on the scrolling mode work to add three buttons for joining
page spreads together: one for the default view, with no page spreads,
and two for spreads starting on odd-numbered or even-numbered pages.
    @rhendric
    rhendric committed May 15, 2018
    Configuration menu
    Copy the full SHA
    3d83c64 View commit details
    Browse the repository at this point in the history

  4. Modify key events for horizontal scrolling 

    Specifically, when there is no vertical scrollbar, let up, down, page
up, and page down all trigger moving to the next or previous page.
    @rhendric
    rhendric committed May 15, 2018
    Configuration menu
    Copy the full SHA
    eaf14e5 View commit details
    Browse the repository at this point in the history

  5. Remember last used scroll and spread modes

    @rhendric
    rhendric committed May 15, 2018
    Configuration menu
    Copy the full SHA
    c24bc29 View commit details
    Browse the repository at this point in the history

  6. Add preferences for default scroll/spread modes 

    This commit adds `scrollModeOnLoad` and `spreadModeOnLoad` preferences
that control the default viewer state when opening a new document for
the first time.

This commit also contains a minor refactoring of some of the option UI
rendering code in extensions/chromium/options/options.js, as I couldn't
bear creating two more functions nearly identical to the four that
already existed.
    @rhendric
    rhendric committed May 15, 2018
    Configuration menu
    Copy the full SHA
    d7c051e View commit details
    Browse the repository at this point in the history