Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 7-Zip on Windows if possible #9564

Closed
wants to merge 1 commit into from

Conversation

IsaacSchemm
Copy link

The "zip" utility is not installed by default on Windows.

If the user is running Windows, this code will check the standard 7-Zip installation directory on the current drive. If 7z.exe is found, it will run that instead of zip.

Potential future issues:

  • 7z and zip use different command line arguments
  • 7-Zip might be installed in a different folder, or on a different drive

@Snuffleupagus
Copy link
Collaborator

The "zip" utility is not installed by default on Windows.

The "correct" solution here, rather than adding a bunch of platform dependent (and program specific code) in gulpfile.js, would probably be to try and use the gulp-zip package for this gulp command too since it's already used elsewhere in this file.

@IsaacSchemm
Copy link
Author

@Snuffleupagus I would agree with that.

@timvandermeij
Copy link
Contributor

This may also become obselete by #9566.

@yurydelendik
Copy link
Contributor

The "zip" utility is not installed by default on Windows.
7-Zip might be installed in a different folder

Zip is a dependency (similar to node) and required to perform task that is obsolete and is not performed on windows. If somebody decide to use it on window, they just need to install "zip", as they would install "7-zip", which is not a standard utility too. Closing as won't fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants