Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix advanced search options (missing Fluent strings, CSS) #3508

Merged
merged 4 commits into from
Jan 6, 2025
Merged

Fix advanced search options (missing Fluent strings, CSS) #3508

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4e509f1
Remove unsupported fa-w class from search options
flodolo Jan 4, 2025
b3d182b
Add/correct Fluent references
flodolo Jan 4, 2025
82745d3
Use kebab case for Fluent IDs
flodolo Jan 6, 2025
5555634
Fix hover state of apply button
flodolo Jan 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions translate/public/locale/en-US/translate.ftl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ editor-FtlSwitch--active =
editor-FailedChecks--close = ×
.aria-label = Close failed checks popup
editor-FailedChecks--title = THE FOLLOWING CHECKS HAVE FAILED
editor-FailedChecks--save-anyway = SAVE ANYWAY
editor-FailedChecks--save-anyway = SAVE ANYWAY
editor-FailedChecks--suggest-anyway = SUGGEST ANYWAY
editor-FailedChecks--approve-anyway = APPROVE ANYWAY

Expand Down Expand Up @@ -468,7 +468,7 @@ interactivetour-InteractiveTour--comments-content =
In the Comments tab you can discuss how to translate content with
your fellow team members. It’s also the place where you can request
more context about or report an issue in the source string.

interactivetour-InteractiveTour--machinery-title = Machinery
interactivetour-InteractiveTour--machinery-content =
The Machinery tab shows automated translation suggestions from
Expand Down Expand Up @@ -682,11 +682,15 @@ search-FiltersPanel--apply-filters =

## Search Options Panel

search-SearchPanel--option-name-identifiers = Search in string identifiers
search-SearchPanel--option-name-search-match-case = Match case
search-SearchPanel--option-name-search-match-whole-word = Match whole word
search-SearchPanel--option-name-search-identifiers = Search in string identifiers
search-SearchPanel--option-name-search-rejected-translations = Include rejected translations
search-SearchPanel--option-name-search-exclude-source-strings = Exclude source strings

search-SearchPanel--heading = SEARCH OPTIONS

search-SearchPanel--apply-options = APPLY SEARCH OPTIONS
search-SearchPanel--apply-search-options = APPLY SEARCH OPTIONS
.title = Apply Selected Search Options

## Time Range Filter
Expand All @@ -700,7 +704,7 @@ search-TimeRangeFilter--save-range = SAVE RANGE
## Term
## Shows term entry with its metadata

term-Term--copy =
term-Term--copy =
.title = Copy Into Translation

term-Term--for-example = E.G.
Expand All @@ -709,9 +713,9 @@ term-Term--for-example = E.G.
## User Avatar
## Shows user Avatar with alt text

user-UserAvatar--anon-alt-text =
user-UserAvatar--anon-alt-text =
.alt = Anonymous User
user-UserAvatar--alt-text =
user-UserAvatar--alt-text =
.alt = User Profile

## User Menu
Expand Down
4 changes: 1 addition & 3 deletions translate/src/modules/search/components/SearchPanel.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,10 +95,8 @@
margin-bottom: 5px;
margin-top: 8px;

&:hover,
.applied-count {
&:hover {
color: var(--status-translated);
margin-top: 35px;
}
}
}
8 changes: 5 additions & 3 deletions translate/src/modules/search/components/SearchPanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,10 @@ const SearchOption = ({
onToggle();
}}
>
<i className='fa fa-w'></i>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this meant to be fa-fw (fixed-width)? In any case, the menu seems to work fine without it.

<Localized id={`search-SearchPanel--option-name-${slug}`}>
<i className='fa'></i>
<Localized
id={`search-SearchPanel--option-name-${slug.replace(/_/g, '-')}`}
>
<span className='label'>{name}</span>
</Localized>
</li>
Expand Down Expand Up @@ -71,7 +73,7 @@ export function SearchPanelDialog({
))}
</ul>

<Localized id='search-SearchPanel--apply-searchOptions'>
<Localized id='search-SearchPanel--apply-search-options'>
<button
title='Apply Selected Search Options'
onClick={onApplyOptions}
Expand Down
Loading