Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use timeago format in Latest Start column of the Sync Log #3548

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

mathjazz
Copy link
Collaborator

@mathjazz mathjazz commented Jan 29, 2025

As discussed on Slack...

Deployed to stage:
https://mozilla-pontoon-staging.herokuapp.com/sync/

@mathjazz mathjazz requested a review from eemeli January 29, 2025 17:41
Copy link
Member

@eemeli eemeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few concerns:

  1. It's not clear what a "month" is? Is it exactly four weeks, or something else? It would probably be better to go from days to weeks to years.
  2. Why is the change only applied to the listing of all projects' most recent sync events, and not the errors view or the project-specific views?
  3. As discussed on Slack, it would probably be best to explicitly use and show (with a trailing Z) UTC timestamps for all non-relative times.

@mathjazz
Copy link
Collaborator Author

mathjazz commented Feb 5, 2025

It's not clear what a "month" is? Is it exactly four weeks, or something else? It would probably be better to go from days to weeks to years.

Yeah, that's how Django works for this feature and it's used across the app already.

Why is the change only applied to the listing of all projects' most recent sync events, and not the errors view or the project-specific views?

The answer is simple and straighforward: I forgot.

As discussed on Slack, it would probably be best to explicitly use and show (with a trailing Z) UTC timestamps for all non-relative times.

I added UTC. I wasn't aware of Z(ulu).

@mathjazz mathjazz requested a review from eemeli February 5, 2025 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants