-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add last_active column to users page #155
Comments
@robotblake This may, in some respects double database writes upon each event in re:Dash. Specifically, when a recordable event call happens it will record the event to re:Dash's meta database and update the user's last_active_at time. Is that something you would have concerns about? |
Discussed in a meeting... we're not especially concerned about this, the write load is pretty low, let's try it out and see how things look in QA. |
With the caveat that we'd want some details on what, exactly, causes the last_active to be updated. We wouldn't want to write on every asset fetch, for instance. Is there already a user_id value in the events table, so that we could do a join to fetch this rather than writing to the user table? |
@rafrombrc - The original concept from Arik was to update the user table. However, there is a user_id field in the events table that is a much better answer. Thanks! |
PR #191 |
From upstream: getredash#789
The text was updated successfully, but these errors were encountered: