Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add last_active column to users page #155

Closed
alison985 opened this issue Jul 24, 2017 · 6 comments
Closed

Add last_active column to users page #155

alison985 opened this issue Jul 24, 2017 · 6 comments

Comments

@alison985
Copy link

alison985 commented Jul 24, 2017

From upstream: getredash#789

@alison985
Copy link
Author

@robotblake This may, in some respects double database writes upon each event in re:Dash. Specifically, when a recordable event call happens it will record the event to re:Dash's meta database and update the user's last_active_at time. Is that something you would have concerns about?

@alison985 alison985 self-assigned this Jul 28, 2017
@rafrombrc
Copy link
Member

Discussed in a meeting... we're not especially concerned about this, the write load is pretty low, let's try it out and see how things look in QA.

@rafrombrc
Copy link
Member

With the caveat that we'd want some details on what, exactly, causes the last_active to be updated. We wouldn't want to write on every asset fetch, for instance. Is there already a user_id value in the events table, so that we could do a join to fetch this rather than writing to the user table?

@alison985
Copy link
Author

@rafrombrc - The original concept from Arik was to update the user table. However, there is a user_id field in the events table that is a much better answer. Thanks!

@alison985 alison985 modified the milestones: 9, 8 Aug 9, 2017
alison985 added a commit to alison985/mozilla-redash that referenced this issue Aug 12, 2017
@alison985
Copy link
Author

PR #191

@madalincm
Copy link

Verified in FF55(Win7) in STMO-stage
Postfix screencast:
lastactive

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants