Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema viewer should not automatically show versioned tables #31

Closed
fbertsch opened this issue Jan 23, 2017 · 12 comments
Closed

Schema viewer should not automatically show versioned tables #31

fbertsch opened this issue Jan 23, 2017 · 12 comments
Assignees
Milestone

Comments

@fbertsch
Copy link

fbertsch commented Jan 23, 2017

In Presto, we have both $TABLENAME, and $TABLENAME_$VERSION, where we have many historical versions of a table. Most of the time, people just need $TABLENAME. Not only does having all the versions clutter the menu, it also slows it down drastically and makes it difficult to use.

I would propose some way to optionally view all versioned datasets for a $TABLENAME.

Note that this is specifically a mozilla thing, and has to do with how we process ETL jobs in our pipeline. Parquet2hive guarantees this $TABLENAME_$VERSION and $TABLENAME convention.

@arikfr
Copy link

arikfr commented Jan 24, 2017

In the no so distant future I want to improve the schema browser & add a dedicated screen for it. As part of this I'm thinking of letting the user decide which tables he wants to show in the schema browser. So you will be able to hide all the $TABLENAME_$VERSION.

Re slow down: that shouldn't happen any more. How many tables/columns do you have?

@fbertsch
Copy link
Author

I just verified again that the slow down occurs. It is very difficult to scroll through the list of tables.

We have 195 tables, of which 164 are versioned tables.

@arikfr
Copy link

arikfr commented Jan 24, 2017

Just noticed that the version you're deploying doesn't have the performance fix I made to the schema browser. So hopefully once you deploy master it will resolve the slow down.

@fbertsch
Copy link
Author

Makes sense, that was going to be my guess as well. Would still like to see the other improvements to the schema browser!

@arikfr
Copy link

arikfr commented Jan 24, 2017

Me too ;-)

@washort
Copy link

washort commented Mar 24, 2017

We'll ignore table names on Presto of the form 'foo_vN' in the schema listing.
bf10361

@fbertsch
Copy link
Author

I don't know if that's a good solution. The versioned tables have different schemas, they should still be available, but only when needed.

@washort
Copy link

washort commented Mar 24, 2017

The schema listing loads everything at once, so we'd have to invent some means for discerning when that should include versioned tables or not.

@washort washort added in progress and removed ready labels Mar 24, 2017
@fbertsch
Copy link
Author

Simple Solution: A button to decide whether to show versioned tables (with copious documentation)

Complex Solution: A button next to each dataset, for whether to show version for that dataset (a little plus)

Sorry, didn't say it was going to be straightfoward :)

@rafrombrc
Copy link
Member

Just confirming that this issue only represents filtering these tables in the UI, we may open another issue to cover the possibility of changing the API to support only pulling down the tables that we need. Yes, we'll add a toggle so the tables can be displayed.

@rafrombrc
Copy link
Member

Recent updates show that the search box is responding much more quickly now, not sure why it was still slow last time I checked. We want to leave this open bc this filtering will still be useful, but deprioritizing bc it's no longer a major pain point.

@rafrombrc rafrombrc removed this from the 4 milestone Apr 5, 2017
@rafrombrc rafrombrc added this to the 6 milestone Jun 21, 2017
@rafrombrc rafrombrc assigned alison985 and unassigned washort Jun 29, 2017
@alison985
Copy link

PR #102

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants