Bug 1661665 - Backport fix wrong Y-axis range for stacked bar chart (#5029) #1012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* getredash#5026 Fix wrong Y-axis range for stacked bar chart * Update tests * Use Plotly's built-in algorinthm to compute Y-axis range * Update tests * Revert previous solution (yRange-related code) * Revert other unrelated changes * Revert other unrelated changes * Move chart rendering to own file and ensure that rendering steps will occur in necessary order * Reduce amount of plot updates by mergin separate updates into a sigle cumulative update * Give better names for several functions
jezdez
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked bar chart with manually set Y-axis min is cut on top getredash/redash#5026 Fix wrong Y-axis range for stacked bar chart
Update tests
Use Plotly's built-in algorinthm to compute Y-axis range
Update tests
Revert previous solution (yRange-related code)
Revert other unrelated changes
Revert other unrelated changes
Move chart rendering to own file and ensure that rendering steps will occur in necessary order
Reduce amount of plot updates by mergin separate updates into a sigle cumulative update
Give better names for several functions
This is just a backport from upstream to fix https://bugzilla.mozilla.org/show_bug.cgi?id=1661665.