Hack to check permissions on inputs to 'Query Results' data source #812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
washort
force-pushed
the
query-results-permissions-hack
branch
from
1ed91f6 to
bc7a519
Compare
jezdez
reviewed
Feb 11, 2019
There was a problem hiding this comment.
Generally speaking I'm not against this type of extension, but it'd be much better to have this in redash-stmo, which I think is possible in this case. You could subclass QueryResultResource and override the get method to do the same check as you've done here. I hope we can simply re-register the updated subclass with Redash via Flask's url endpoints or if needed monkeypatch it in. What do you think?
|
Superseded by mozilla/redash-stmo#20 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This looks at the query used against the 'query results' data source, identifies the queries it targets, and checks that the user has permission to view results from those queries. If not, permission is not granted to view the output.