Do not strip binaries #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #421 +/- ##
=======================================
Coverage 22.18% 22.18%
=======================================
Files 45 45
Lines 5797 5797
Branches 822 822
=======================================
Hits 1286 1286
Misses 3988 3988
Partials 523 523 Continue to review full report at Codecov.
|
Luni-4
changed the title
Luni-4
changed the title
marco-c
reviewed
Jan 15, 2021
marco-c
approved these changes
Jan 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rustprograms are able to print a stacktrace thanks to the debug info in the file, so stripping them will probably kill this nice and very useful feature. It would a way better in general to propose the binary as compiled byrustc