Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add SCCACHE_GCS_CREDENTIALS_URL feature back for gcs #1494

Merged
merged 1 commit into from
Dec 20, 2022

Conversation

Xuanwo
Copy link
Collaborator

@Xuanwo Xuanwo commented Dec 20, 2022

Signed-off-by: Xuanwo github@xuanwo.io

This PR will add SCCACHE_GCS_CREDENTIALS_URL feature back so that Mozilla can use sccache in CI without changing existing config.

Signed-off-by: Xuanwo <github@xuanwo.io>
@codecov-commenter
Copy link

codecov-commenter commented Dec 20, 2022

Codecov Report

Base: 30.06% // Head: 29.93% // Decreases project coverage by -0.12% ⚠️

Coverage data is based on head (7d4cade) compared to base (ddb057a).
Patch coverage: 8.10% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1494      +/-   ##
==========================================
- Coverage   30.06%   29.93%   -0.13%     
==========================================
  Files          47       47              
  Lines       16642    16676      +34     
  Branches     7873     7900      +27     
==========================================
- Hits         5003     4992      -11     
- Misses       6328     6366      +38     
- Partials     5311     5318       +7     
Impacted Files Coverage Δ
src/cache/gcs.rs 10.86% <0.00%> (-18.55%) ⬇️
src/cache/cache.rs 36.18% <50.00%> (+0.89%) ⬆️
src/config.rs 35.97% <50.00%> (+0.33%) ⬆️
src/compiler/gcc.rs 54.85% <0.00%> (-0.73%) ⬇️
src/server.rs 31.67% <0.00%> (-0.53%) ⬇️
src/lib.rs 8.76% <0.00%> (-0.35%) ⬇️
src/util.rs 33.76% <0.00%> (-0.33%) ⬇️
src/compiler/msvc.rs 43.42% <0.00%> (-0.27%) ⬇️
src/compiler/compiler.rs 35.84% <0.00%> (-0.15%) ⬇️
... and 8 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sylvestre sylvestre merged commit 8a3bc9c into mozilla:main Dec 20, 2022
@Xuanwo Xuanwo deleted the add-back-task-cluster-support branch December 20, 2022 08:34
@sylvestre
Copy link
Collaborator

Looks like it fixed Firefox CI:
https://firefoxci.taskcluster-artifacts.net/THQ6jVgKSf-gL9XiYaxKSQ/0/public/build/sccache.log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants