-
Notifications
You must be signed in to change notification settings - Fork 557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation for Cloudflare R2 usage. #1549
Conversation
@@ -28,6 +28,7 @@ Table of Contents (ToC) | |||
* Storage Options | |||
* [Local](docs/Local.md) | |||
* [S3](docs/S3.md) | |||
* [R2](docs/S3.md#R2) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if we need separate section for all s3-compatible services. Maybe inside S3.md
is enough?
Leave this for maintainers @sylvestre @drahnr to decide.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably not needed here, but maybe worth changing S3
to S3 and compatible
or something similar?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice idea to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sounds good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe worth changing
S3
toS3 and compatible
or something similar?
Please do this change, others LGTM~
Codecov ReportBase: 30.91% // Head: 30.93% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1549 +/- ##
==========================================
+ Coverage 30.91% 30.93% +0.01%
==========================================
Files 48 48
Lines 16589 16589
Branches 7896 7898 +2
==========================================
+ Hits 5129 5131 +2
+ Misses 6107 6104 -3
- Partials 5353 5354 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Updated the S3 doc to be more informative and removed the unused env vars as well. |
R2 is S3-compatible. Here are some light docs on how to use it.