Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs on integrating sccache with MSVC when cmake >= 3.25 #2031

Merged
merged 3 commits into from
Jan 16, 2024

Conversation

johnwbyrd
Copy link
Contributor

Documentation was incomplete, in the situation where sccache is compiling a cmake project with MSVC, only if the version of cmake is equal to or greater than 3.25. The CMP0141 is required in order to get the new behavior with CMAKE_MSVC_DEBUG_INFORMATION_FORMAT. I rewrote the readme to not assume the older version of cmake.

@Xuanwo
Copy link
Collaborator

Xuanwo commented Jan 15, 2024

cc @sylvestre for a review.

@codecov-commenter
Copy link

codecov-commenter commented Jan 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9d1696b) 30.87% compared to head (42c929a) 31.08%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2031      +/-   ##
==========================================
+ Coverage   30.87%   31.08%   +0.21%     
==========================================
  Files          51       51              
  Lines       19624    19585      -39     
  Branches     9420     9410      -10     
==========================================
+ Hits         6058     6088      +30     
+ Misses       7876     7836      -40     
+ Partials     5690     5661      -29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
johnwbyrd and others added 2 commits January 16, 2024 01:17
Co-authored-by: Sylvestre Ledru <sylvestre@debian.org>
@sylvestre sylvestre merged commit 40866af into mozilla:main Jan 16, 2024
11 checks passed
@johnwbyrd
Copy link
Contributor Author

Thanks for fixing it.

@sylvestre
Copy link
Collaborator

happy to help :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants