Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add possibility to configure key prefix and expiration time from env (Redis, MemCached) #2094

Merged
merged 5 commits into from
Feb 20, 2024

Conversation

AJIOB
Copy link
Contributor

@AJIOB AJIOB commented Feb 15, 2024

  • Unifying the way for parsing all ..._KEY_PREFIX variables from env
  • Add the way for reading numbers from env

@AJIOB
Copy link
Contributor Author

AJIOB commented Feb 15, 2024

Hi @Xuanwo,

Looks like we have some test data races or the compiler bug, isn't it?

Let's try to restart the failed build.

@sylvestre sylvestre force-pushed the AJIOB/unify-env-values-format branch from 0f4ac1c to b0332ca Compare February 16, 2024 19:55
@codecov-commenter
Copy link

codecov-commenter commented Feb 16, 2024

Codecov Report

Attention: 34 lines in your changes are missing coverage. Please review.

Comparison is base (7248d18) 30.77% compared to head (b0332ca) 30.83%.

Files Patch % Lines
src/config.rs 8.10% 25 Missing and 9 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2094      +/-   ##
==========================================
+ Coverage   30.77%   30.83%   +0.06%     
==========================================
  Files          52       52              
  Lines       19944    19940       -4     
  Branches     9658     9654       -4     
==========================================
+ Hits         6137     6148      +11     
+ Misses       7942     7938       -4     
+ Partials     5865     5854      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@AJIOB
Copy link
Contributor Author

AJIOB commented Feb 20, 2024

@Xuanwo , let's merge it?

@sylvestre sylvestre merged commit 6ebc516 into mozilla:main Feb 20, 2024
49 checks passed
@AJIOB AJIOB deleted the AJIOB/unify-env-values-format branch February 23, 2024 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants