Cache rmeta files whenever metadata is present in emit. #441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luser
reviewed
May 31, 2019
src/compiler/rust.rs
Outdated
| @@ -915,7 +916,7 @@ fn parse_arguments(arguments: &[OsString], cwd: &Path) -> CompilerArguments<Pars | |||
| staticlibs: staticlibs, | |||
| crate_name: crate_name.to_string(), | |||
| dep_info: dep_info.map(|s| s.into()), | |||
| rename_rlib_to_rmeta, | |||
| emit: emit, | |||
There was a problem hiding this comment.
Suggested change
| emit: emit, | |
| emit, |
luser
reviewed
May 31, 2019
src/compiler/rust.rs
Outdated
| // be fixed. | ||
| if !outputs.contains(&rmeta) { | ||
| outputs.push(rmeta); | ||
| }; |
luser
reviewed
May 31, 2019
src/compiler/rust.rs
Outdated
| }; | ||
| if !emit.contains("link") { | ||
| outputs.retain(|p| *p != lib); | ||
| }; |
|
@chmanchester Thanks, this was driving me crazy! |
7 tasks
chmanchester
added a commit
to chmanchester/sccache
that referenced
this pull request
Jun 25, 2019
chmanchester
added a commit
that referenced
this pull request
Jun 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #436, Fixes #429