feat/rust: cargo toml as part of hash #719
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solves a corner case when a procmacro relies upon Cargo.toml availability to retrieve crate aliases from Cargo.toml. Issue: mozilla#676 Side effects: Cache invalidation on Cargo.toml comment changes, the hash changes and as such the cache breaks.
Causes false negatives when Cargo.toml changed, cache lookups will still succeed.
drahnr
force-pushed
the
feat-cargo-toml-as-part-of-hash
branch
from
8a4b6cb to
525ceab
Compare
|
Besides the merge conflicts, I'd still be interested in getting some feedback here :) |
|
Can you detail the reason behind this PR? |
|
Until I get around to impl rust-lang/rust#73921 this was an initial workaround to make sccache usable for builds like https://github.com/paritytech/substrate which needs to resolve |
|
Closing per #719 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A questionable addition, regarding adding
Cargo.tomlto the assets for distributed compiles and also make it part of the hash lookup key.Causes cache invalidation on Cargo.toml change, which is probably not anticipated.
Issue #675 - additive Cargo.toml for each rust dist compile request makes not too much sense right now, the negative impact is pretty big for a config key change