Add prettier support, via 'npm run format' #109
Conversation
|
Main comment: perhaps I am ignorant, but this feels like eslint, and prettier are in conflict about many aspects here. I appreciate the work on this, and trying to see how gory the changes are! Some seem obviously good and some seem... gory! /me off to look more at how prettier work. |
|
Yeah, Prettier and ESLint rules and configs can definitely conflict, so it's generally better to disable any Prettier formatting-related rules (quotes, trailing commas, spacing) in ESLint so they don't fight each other. Or if you want to go the "prettier in eslint" route, I can try submitting a separate PR for that so we can battle them side-by-side. I've gotten it working in the past, but sometimes formatting errors will show up in ESLint with less than helpful error messages. |
|
But let me know if you have any specific "gore" that you want me to research. Naturally we can have Prettier ignore JSON files, or Markdown files or other things where formatting is less helpful. |
|
Mostly I need to learn a lot more about what things it has opinions on.
The only one that annoyed me was collapsing arrays :).
How can we play best with Mozilla code in general :)
…On Wed, Nov 29, 2017 at 7:38 PM Peter deHaan ***@***.***> wrote:
But let me know if you have any specific "gore" that you want me to
research. Naturally we can have Prettier ignore JSON files, or Markdown
files or other things where formatting is less helpful.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#109 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAKAjzdlOrqo8TZbp2OinaHUgQrdtWtCks5s7gcxgaJpZM4QuXAz>
.
|
|
In the template, this is currently under review. |
|
The changes in this PR were rebased and included in #119 which is now merged. |
Dearest @gregglind,
You can see what I mean about it being a pretty sizable (and unstable) diff.
Prettier doesn't offer a ton of configuration options, but if there is something you find horribly offensive below, I think we can do some "ignore" blocks for certain code, or add specific files/folders/extensions to the .prettierignore file.