Migrate to wasm-bindgen #474
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While looking at #473 I realized that we may benefit from migrating to wasm-bindgen instead of bundling rust's wasm very manually. Hopefully this may handle some type convertion for us. But it would also ease logging from the Rust code and use the typical toolchain to integrate Rust into nodejs/browser apps.
Unfortunately, this isn't actionnable just yet. This is blocked on supporting ES Modules in Workers in Firefox.
wasm-bindgen only support generating ES Modules for browser target.
Using
nodejstarget introduce the usage of various node-only modules (path and fs).The
no-modulestarget isn't easily usage in Firefox codebase from our CommonJS loader. (Nor from nodejs)Hopefully we start support workers soon in Firefox as this patch would also allow loading the WASM synchronously in nodejs.
This would ultimately help get rid of async APIs in the library! And we would also be able to migrate to ES Modules in all modules.