Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: don't fix with lint target #490

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nschonni
Copy link

Since the lint target is called with the --fix parameter, the CI wouldn't fail if there were autofixable issues. Split the fix vs lint targets, and reused Prettiers ignore file instead of creating a .eslintignore file

Copy link
Member

@eemeli eemeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than changing the behaviour of npm run lint, it'd be better to change the command used in CI to directly call npx eslint without the --fix argument.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants