-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to YAML and GitHub data #1063
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking forward to this work being ready.
Are you planning to add a workflow for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed with this direction and simplification.
7c6801f
to
3fd8172
Compare
66bf7e5
to
8431e75
Compare
This should be ready now, except the GH Actions need a deploy key and environment secret for this repo which I can't add currently. |
This is now done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This certainly seems like an improvement.
I have a few questions about the complex deployment architecture here, but I assume that most of this is there for good reasons (that I don't understand). I'm OK with shipping this.
Not sure if this should be part of this PR, but it might be a good idea to enable |
I would really prefer that we write the content directly into index.html during merge-data instead of loading the JSON at runtime and client side templating (to avoid some of the workarounds for fragment functionality etc). That said, we can work through that in followups, and this is overall a big simplification for the frontend (including removing many dependencies) |
I'm good with the change, pending any updates to the actions that you're looking into. |
…merged-data.json.
This changes the data format for activities from JSON to YAML, and uses information from the GitHub issues (the OP and labels). The data is presented on a new dashboard website. There's a workflow to push the
merged-data.json
file togh-pages
to publish.