Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to YAML and GitHub data #1063

Merged
merged 22 commits into from
Nov 20, 2024
Merged

Switch to YAML and GitHub data #1063

merged 22 commits into from
Nov 20, 2024

Conversation

zcorpan
Copy link
Member

@zcorpan zcorpan commented Aug 28, 2024

This changes the data format for activities from JSON to YAML, and uses information from the GitHub issues (the OP and labels). The data is presented on a new dashboard website. There's a workflow to push the merged-data.json file to gh-pages to publish.

Copy link
Member

@martinthomson martinthomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking forward to this work being ready.

Are you planning to add a workflow for this?

gh-data.py Outdated Show resolved Hide resolved
gh-data.py Outdated Show resolved Hide resolved
gh-data.py Outdated Show resolved Hide resolved
activities.yml Show resolved Hide resolved
gh-data-summary.json Outdated Show resolved Hide resolved
Copy link
Member

@tantek tantek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed with this direction and simplification.

@zcorpan
Copy link
Member Author

zcorpan commented Nov 7, 2024

I've made a new website here. To preview, check out this branch and start a local server (python3 -m http.server). It supports ligth mode and dark mode, searching, and color contrast issues are addressed. New "Mozilla" branding also.

Screenshot (light mode) Screenshot (dark mode)

@zcorpan zcorpan changed the title Switch to YAML and GitHub data (WIP) Switch to YAML and GitHub data Nov 15, 2024
@zcorpan zcorpan marked this pull request as ready for review November 15, 2024 00:23
@zcorpan
Copy link
Member Author

zcorpan commented Nov 15, 2024

This should be ready now, except the GH Actions need a deploy key and environment secret for this repo which I can't add currently.

@tantek tantek requested a review from bgrins November 18, 2024 18:53
@zcorpan
Copy link
Member Author

zcorpan commented Nov 18, 2024

except the GH Actions need a deploy key and environment secret for this repo which I can't add currently.

This is now done.

Copy link
Member

@martinthomson martinthomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This certainly seems like an improvement.

I have a few questions about the complex deployment architecture here, but I assume that most of this is there for good reasons (that I don't understand). I'm OK with shipping this.

.github/workflows/build-and-deploy.yml Outdated Show resolved Hide resolved
DEVELOP.md Outdated Show resolved Hide resolved
@larseggert
Copy link

Not sure if this should be part of this PR, but it might be a good idea to enable dependabot and actionlint for this repo?

@bgrins
Copy link
Member

bgrins commented Nov 19, 2024

I would really prefer that we write the content directly into index.html during merge-data instead of loading the JSON at runtime and client side templating (to avoid some of the workarounds for fragment functionality etc). That said, we can work through that in followups, and this is overall a big simplification for the frontend (including removing many dependencies)

@bgrins
Copy link
Member

bgrins commented Nov 19, 2024

I'm good with the change, pending any updates to the actions that you're looking into.

@zcorpan zcorpan merged commit 8f6fae9 into main Nov 20, 2024
1 check passed
@zcorpan zcorpan deleted the zcorpan/yaml-and-gh-data branch November 20, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants