Skip to content
This repository has been archived by the owner on Dec 5, 2019. It is now read-only.

Extend the OIDC authentication backend with the ability to verify remote user groups against a configured list of allowed user groups. #982

Merged
merged 1 commit into from
Feb 1, 2018

Conversation

jezdez
Copy link
Contributor

@jezdez jezdez commented Jan 24, 2018

Disabled by default as it requires deployment changes.

Fix #978.

Copy link
Contributor

@robotblake robotblake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me, I'll wait for @washort's take though.

@codecov-io
Copy link

codecov-io commented Jan 24, 2018

Codecov Report

Merging #982 into master will decrease coverage by 0.24%.
The diff coverage is 54.54%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #982      +/-   ##
==========================================
- Coverage   93.63%   93.38%   -0.25%     
==========================================
  Files          47       48       +1     
  Lines        1727     1738      +11     
  Branches      164      165       +1     
==========================================
+ Hits         1617     1623       +6     
- Misses         88       93       +5     
  Partials       22       22
Impacted Files Coverage Δ
atmo/settings.py 91.41% <100%> (+0.1%) ⬆️
atmo/users/backends.py 44.44% <44.44%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1598ce1...e33bf94. Read the comment docs.

…ote user groups against a configured list of allowed user groups.

Disabled by default as it requires deployment changes.

Fix #978.
@jezdez jezdez force-pushed the verify-claims-auth0 branch from 5725b2d to e33bf94 Compare January 26, 2018 16:26
@jezdez
Copy link
Contributor Author

jezdez commented Jan 31, 2018

This will need two env vars to be set:

  • DJANGO_REMOTE_GROUPS_ENABLED=true
  • DJANGO_REMOTE_GROUPS_ALLOWED=group1,group2

@jezdez jezdez merged commit 581b4d2 into master Feb 1, 2018
@jezdez jezdez deleted the verify-claims-auth0 branch February 1, 2018 15:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants