Bug 1468658 - Fix & enable more ESLint rules #3665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eslint.org/docs/rules/quotes Changes performed by `--fix`.
https://eslint.org/docs/rules/spaced-comment Changes performed by `--fix`.
https://eslint.org/docs/rules/space-infix-ops Changes performed by `--fix`.
https://eslint.org/docs/rules/comma-dangle Changes performed by `--fix`.
Since the rule is disabled entirely in `lint.js` for now.
camd
approved these changes
Jun 14, 2018
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I held off landing this until #3621 merged to reduce the number of conflicts.
There will likely still be conflicts with some of the other WIP React conversion PRs, but there's never going to be a perfect time - and I think we need to get more of these rules enabled sooner rather than later, since there are already quite a few AirBnb style deviations being introduced into the new code (unsurprisingly since without the linter its hard to avoid). For conflicts that do occur, since these rules are all
--fixable, resolving them should be easier.Other than a few tweaks to the style of multi-line comments for the
spaced-commentcommit, all of the other changes were entirely the result of--fix.See individual commits for more details.