Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade clap #1383

Closed
wants to merge 1 commit into from
Closed

Upgrade clap #1383

wants to merge 1 commit into from

Conversation

jplatte
Copy link
Collaborator

@jplatte jplatte commented Oct 25, 2022

No description provided.

@jplatte jplatte requested a review from a team as a code owner October 25, 2022 11:36
@jplatte jplatte requested review from jhugman and removed request for a team October 25, 2022 11:36
@jplatte jplatte mentioned this pull request Oct 25, 2022
Merged
@badboy
Copy link
Member

badboy commented Oct 25, 2022

Copying my comment:

The clap update requires a whole bunch of new audits in m-c, for which I currently won't have the time, so I'd rather hold back on that for the time being.

@jhugman jhugman requested review from badboy and removed request for jhugman October 26, 2022 16:00
@jhugman
Copy link
Contributor

jhugman commented Oct 26, 2022

Deferring to @badboy who has more context than me on this.

@jplatte jplatte mentioned this pull request Nov 1, 2022
Merged
@jplatte
Copy link
Collaborator Author

jplatte commented Mar 20, 2023

Any update on this? Just curious, no big problems from keeping clap 3.

@mhammond
Copy link
Member

moz-central is still on clap 3, and it's used by tooling that's probably not going to drive an upgrade. So sadly nothing has changed, nor is likely to change soon with a driver, and any such driver needs to jump through those auditing hooks.

@badboy
Copy link
Member

badboy commented Jun 2, 2023

m-c is being updated so we can also pull this in.

@jplatte can you rebase this?

@badboy
Copy link
Member

badboy commented Jun 2, 2023

oh, right, we moved clap to uniffi: b0aae80

@badboy
Copy link
Member

badboy commented Jun 2, 2023

Oh, because of further changes this got a bit more complex. I'm looking into it.

@badboy badboy mentioned this pull request Jun 5, 2023
Merged
@jplatte
Copy link
Collaborator Author

jplatte commented Jun 5, 2023

Superseded by #1583.

@jplatte jplatte closed this Jun 5, 2023
@jplatte jplatte deleted the jplatte/upgrade-clap branch June 5, 2023 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@badboy badboy Awaiting requested review from badboy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jplatte @badboy @jhugman @mhammond