Add External resources to the README #1419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes mozilla#1418 and maybe mozilla#441.
|
This looks great to me, thanks! We could maybe have an extra disclaimer that these aren't endorsed by uniffi, but TBH I don't really think that's necessary - there's no implication they are! But what to others think? In the meantime, @benkuly, are you happy with the wording there? |
It has the word "third-party" in there, which IMO is already good enough. |
|
lgtm! thank you :) |
badboy
approved these changes
Dec 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1418 and maybe #441.
Please let me know if I should word some parts differently. I can't speak for #441 myself but I put part of its README in there (without mentioning future plans, which may or not happen, to avoid putting more pressure on the project).