Default parameters in constructors #1840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
badboy
commented
Nov 10, 2023
mhammond
reviewed
Nov 13, 2023
|
In order to get something landed and to reduce the scope I'm splitting this in two: the record constructor and the normal function and its argument's order. This PR is now purely for the constructor as that seems uncontroversial. |
badboy
changed the title
badboy
force-pushed
the
1658/record-default-values-in-any-order
branch
from
830570b to
8d40d92
Compare
|
There's a bunch of tests that are affected by this change. So I'll wait for feedback if we go with this before spending the time on fixing them. |
jeddai
approved these changes
Dec 18, 2023
badboy
force-pushed
the
1658/record-default-values-in-any-order
branch
2 times, most recently
from
1d2e20a to
b9f16a3
Compare
BREAKING CHANGE: Named arguments to struct constructors are now required. Note that this now allows default values before non-default ones, which previously lead to a syntax error in generated Python.
…t values in struct constructors BREAKING CHANGE: Named arguments are now required.
badboy
force-pushed
the
1658/record-default-values-in-any-order
branch
from
b9f16a3 to
2e5bc9f
Compare
mgeisler
added a commit
to mgeisler/mls-rs
that referenced
this pull request
Mar 22, 2024
UniFFI added support for async traits in mozilla/uniffi-rs#1981, but this is not yet released. This commit temporarily introduces a Git dependency on UniFFI to let us test the async functionality which was removed in awslabs#86. An unrelated UniFFI change (mozilla/uniffi-rs#1840) made our existing test fail.
mgeisler
added a commit
to mgeisler/mls-rs
that referenced
this pull request
Mar 22, 2024
UniFFI added support for async traits in mozilla/uniffi-rs#1981, but this is not yet released. This commit temporarily introduces a Git dependency on UniFFI to let us test the async functionality which was removed in awslabs#86. An unrelated UniFFI change (mozilla/uniffi-rs#1840) made our existing test fail.
mgeisler
added a commit
to mgeisler/mls-rs
that referenced
this pull request
Mar 23, 2024
UniFFI added support for async traits in mozilla/uniffi-rs#1981, but this is not yet released. This commit temporarily introduces a Git dependency on UniFFI to let us test the async functionality which was removed in awslabs#86. An unrelated UniFFI change (mozilla/uniffi-rs#1840) made our existing test fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a two-parter:The first 2 commits essentially implement what we discussed in #1658:
Struct constructors use named parameters in the foreign language.
This is enforced for Ruby and Python. Swift enforces it by default anyway, in Kotlin it's optional but usable (I don't think one can enforce the names)
That means default values at any position just work.
Note: default values for constructors aren't implemented for Ruby in
mainright now at all.The last commit looks at default values in functions:Right now we happily accept default values for any of the arguments, which will break for Python and Ruby if any defaulted args come before non-defaulted ones.I put this up as one PR for now, but that doesn't mean it's final.I'd be happy to split it up later.Personally I think for constructors it's not so controversial anymore (but awaiting final decision in #1658).For functions it's unclear right now.