Python error handling #215
Conversation
uniffi_bindgen/src/bindings/python/templates/TopLevelFunctionTemplate.py
Outdated
Show resolved
Hide resolved
|
Thanks for the feedback, it's probably fine now! |
There was a problem hiding this comment.
Thanks! I left a couple of very minor comments below, but this looks really good overall.
(I'm going to wait to hear from @linacambridge over in #221 to make sure we don't generate merge conflicts with her work, before merging this)
| try { | ||
| sub(0, 2) | ||
| throw RuntimeException("Should have thrown a IntegerOverflow exception!") | ||
| } catch (e: ArithmeticErrorException) { |
There was a problem hiding this comment.
In swift and python we explicitly test that this was the IntegerOverflow variant, but here we test only that it was an ArithmeticError. Does it work if we catch ArithmeticErrorException.IntegerOverflow here like the other languages do?
(I note that the todolist example has a similar problem, but we don't need to fix that here)
| _UniFFILib.{{ func.ffi_func().name() }}({% call _arg_list_ffi_call(func.arguments()) -%}) | ||
| {%- match func.throws() -%} | ||
| {%- when Some with (e) -%} | ||
| rust_call_with_error({{ e|class_name_py }},_UniFFILib.{{ func.ffi_func().name() }},{% call _arg_list_ffi_call(func) -%}) |
There was a problem hiding this comment.
Nice, I really like how this worked out in practice 👍
This PR add support for Python error handling
Closes #202
Closes #206