Render all types of literal in the python bindings. #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfk
force-pushed
the
python-literal-rendering
branch
from
277594a to
cec3ffc
Compare
jhugman
approved these changes
Sep 29, 2020
I'm really pleased to see
Comment on lines
+70
to
+76
| Literal::Boolean(v) => { | ||
| if *v { | ||
| "True".into() | ||
| } else { | ||
| "False".into() | ||
| } | ||
| } |
Comment on lines
+86
to
+88
| // TODO: render with the intended radix. | ||
| Literal::Int(i, _radix, _type_) => format!("{}", i), | ||
| Literal::UInt(i, _radix, _type_) => format!("{}", i), |
There was a problem hiding this comment.
#300 will be interested in this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I should have rebased #214 before merging, as the new python rondpoint tests interacted badly with the concurrent PR to add support for default arguments. This PR does just enough work to unbreak CI, but doesn't add any tests or similar for the actual use of optional args in python. That work is tracked in #300