Added tests for defaultCreateProfileFinder()

mozilla · Jun 22, 2017 · bfb1703 · bfb1703
1 parent fdff679
commit bfb1703
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 5 deletions.
diff --git a/src/firefox/index.js b/src/firefox/index.js
@@ -247,15 +247,18 @@ export type UseProfileParams = {
   createProfileFinder?: typeof defaultCreateProfileFinder,
 };
 
-export function defaultCreateProfileFinder(userDirectoryPath: string = '') {
+export function defaultCreateProfileFinder(userDirectoryPath?: string) {
   const finder = new FirefoxProfile.Finder(userDirectoryPath);
   const readProfiles = promisify(finder.readProfiles, finder);
   return {
     getPath: promisify(finder.getPath, finder),
     hasProfileName: async (profileName: string) => {
       try {
-        await fs.stat(path.join(FirefoxProfile.Finder.locateUserDirectory(),
-                                                              'profiles.ini'));
+        const profilesIniPath = path.join(
+          userDirectoryPath || FirefoxProfile.Finder.locateUserDirectory(),
+          'profiles.ini');
+
+        await fs.stat(profilesIniPath);
         await readProfiles();
         return finder.profiles.filter(
           (profileDef) => profileDef.Name === profileName).length !== 0;

diff --git a/tests/unit/test-firefox/test.firefox.js b/tests/unit/test-firefox/test.firefox.js
@@ -783,7 +783,6 @@ describe('firefox', () => {
   });
 
   describe('defaultCreateProfileFinder', () => {
-
     it('gives a warning if no firefox profiles exist', () => withTempDir(
       async (tmpDir) => {
         try {
@@ -797,6 +796,24 @@ describe('firefox', () => {
         }
       }
   ));
-
+    it('gives a warning if no firefox profiles exist', () => withTempDir(
+      async (tmpDir) => {
+        try {
+          const profilesPath = tmpDir.path();
+          const profileFinder = firefox.defaultCreateProfileFinder(
+                                  profilesPath);
+          const profilesIniPath = path.join(profilesPath, 'profiles.ini');
+          const profileContents = `[Profile0]
+Name=test
+IsRelative=1
+Path=fake-profile.test`;
+          await fs.writeFile(profilesIniPath, profileContents);
+          const profileExists = await profileFinder.hasProfileName('test');
+          assert.equal(profileExists, true);
+        } catch (e) {
+          throw e;
+        }
+      }
+    ));
   });
 });