Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[meta] nodejs 17 compatibility issues #2337

Closed
5 tasks done
rpl opened this issue Oct 26, 2021 · 2 comments
Closed
5 tasks done

[meta] nodejs 17 compatibility issues #2337

rpl opened this issue Oct 26, 2021 · 2 comments

Comments

@rpl
Copy link
Member

rpl commented Oct 26, 2021

There are currently more than one issue that prevent web-ext run to fully work on nodejs 17, the main issue seems to be related to the default behavior of the dns resolution (see nodejs/node#40537 and nodejs/node#39987).

The following web-ext internals seems to have issues:

  • ChromiumExtensionRunner
    • due to the ws url generated from the WebSocketServer's address and port not be in a valid format when address is an IPv6
    • due to chrome-launcher dependency trying to connect to IPv6 while Chrome is listening on IPv4
  • FirefoxAndroidExtensionRunner
    • due to @devicefarmer/adbkit defaulting to an IPv6 adbHost, while adb is likely still listening on IPv4 (similarly to the chrome-launcher issue)

web-ext issues and pull requests

upstream issues and pull requests

@eight04
Copy link
Contributor

eight04 commented Oct 27, 2021

chrome-launcher issue:
GoogleChrome/chrome-launcher#251

@rpl
Copy link
Member Author

rpl commented Nov 26, 2021

@eight04 Thanks a lot for your help on investigating, reporting to the upstream repos, and fixing these nodejs 17 issues on web-ext side too, that was all very much appreciated ❤️

I included the fixes for the issues we are currently aware of in the 6.6.0 version that we have just released on npm, and so I'm going to close this meta issue as fixed (we can file new issue if we discover other issues that prevents web-ext to work correctly on nodejs 17).

@rpl rpl closed this as completed Nov 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants