-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Run tests on windows using travis #1385
Conversation
There is currently one unit test that wasn't failing on appveyor (and it doesn't fail when running locally), but it fails (on both nodejs 6 and nodejs 8) with the following error message:
(e.g. See https://travis-ci.org/rpl/web-ext/jobs/448006862#L1981-L1986) Currently I've added the failing unit test to the ones that are currently skipped when running on windows (but I'm thinking that we could opt to detect the windows travis worker instead and only skip it there), anyway I'm prone to think that it is still reasonable to proceed with skipping the failing test in this PR and file a follow up to investigate the failure and re-enable it on travis windows jobs. |
@kumar303 it looks that we have to also explicitly disable appveyor in the settings of the github repo, otherwise appveyor is going to still try to run on every pull request (and fail consistently because of the removed appveyor.yml file). |
4678cbb
to
4dbf220
Compare
Fix #1380