Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Run tests on windows using travis #1385

Merged
merged 1 commit into from
Oct 31, 2018

Conversation

rpl
Copy link
Member

@rpl rpl commented Oct 30, 2018

Fix #1380

@rpl
Copy link
Member Author

rpl commented Oct 30, 2018

There is currently one unit test that wasn't failing on appveyor (and it doesn't fail when running locally), but it fails (on both nodejs 6 and nodejs 8) with the following error message:

1) util/extension-runners
       defaultReloadStrategy
         allows you to disable input:
     Uncaught Error: read EISDIR
      at exports._errnoException (util.js:1020:11)
      at TTY.onread (net.js:580:26)

(e.g. See https://travis-ci.org/rpl/web-ext/jobs/448006862#L1981-L1986)

Currently I've added the failing unit test to the ones that are currently skipped when running on windows (but I'm thinking that we could opt to detect the windows travis worker instead and only skip it there), anyway I'm prone to think that it is still reasonable to proceed with skipping the failing test in this PR and file a follow up to investigate the failure and re-enable it on travis windows jobs.

@rpl rpl requested a review from Rob--W October 30, 2018 12:18
@rpl
Copy link
Member Author

rpl commented Oct 30, 2018

@kumar303 it looks that we have to also explicitly disable appveyor in the settings of the github repo, otherwise appveyor is going to still try to run on every pull request (and fail consistently because of the removed appveyor.yml file).

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 7f689fb on rpl:wip/travis-windows-jobs into 7d8b703 on mozilla:master.

@coveralls
Copy link

coveralls commented Oct 30, 2018

Coverage Status

Coverage remained the same at 100.0% when pulling 4dbf220 on rpl:wip/travis-windows-jobs into 7d8b703 on mozilla:master.

@rpl rpl merged commit 069f251 into mozilla:master Oct 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants