fix: Prevent travis windows worker from trying to deploy new tags on npm #1396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rob--W
reviewed
Nov 10, 2018
rpl
force-pushed
the
fix/skip-deploy-on-travis-windows-workers
branch
from
ada4a72
to
01218f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the travis windows worker fails on tagged releases because it tries to deploy on npm, e.g. see:
https://travis-ci.org/mozilla/web-ext/jobs/452842982#L1228
Deploying on npm from the travis window worker is not something that we really want (or care about) and so we should ask travis to skip the deploy task completely on any windows job.
Based on the relevant travis docs this change should avoid that (unfortunately we will learn if it worked as expected only once we create the next tag).