fix: Deprecated support for nodejs 6 #1490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 similar comments
|
Looks good to me. Is this a standalone PR, or do you want to add more commits to modernize the code/dependencies after unsupporting Node 6? |
@Rob--W yep it is a standalone PR, I think that it is better to land this change immediately and work on the further changes needed to modernize the project in separate PRs (so that we don't have to block more pressing changes that are depending from this one, e.g. update the addons-linter dependency, on completing all those additional changes). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As announced in the 2.9.3 release notes, this PR is going to officially deprecate support for node versions < 8 (and remove node 6 from the travis job matrix).
👋 nodejs 6