Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Reset browser.link.open_newwindow on desktop Firefox too. #1766

Merged
merged 1 commit into from
Nov 25, 2019

Conversation

emilio
Copy link
Contributor

@emilio emilio commented Nov 24, 2019

This confused me quite a lot, see
https://bugzilla.mozilla.org/show_bug.cgi?id=1598947

Changing the default behavior of target="_blank" is quite arbitrary and
unexpected, IMO.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 19051e1 on emilio:master into 3c850ae on mozilla:master.

@coveralls
Copy link

coveralls commented Nov 24, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling 30894fe on emilio:master into 3c850ae on mozilla:master.

This confused me quite a lot, see
https://bugzilla.mozilla.org/show_bug.cgi?id=1598947

Changing the default behavior of target="_blank" is quite arbitrary and
unexpected, IMO.
@emilio emilio changed the title Reset browser.link.open_newwindow on desktop Firefox too. fix: Reset browser.link.open_newwindow on desktop Firefox too. Nov 24, 2019
@emilio
Copy link
Contributor Author

emilio commented Nov 24, 2019

npm run audit-deps is failing, but that doesn't seem related to my change.

Copy link
Member

@Rob--W Rob--W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. This has annoyed me for a while too.

If you'd like to use this feature before the new version is published, create ~/.web-ext-config.js with the following content:

module.exports = {
  run: {
    pref: [
      // https://github.com/mozilla/web-ext/pull/1766
      "browser.link.open_newwindow=3",
    ],
  }
};

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants