Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable data reporting and “Choose what I share” notification #1883

Merged
merged 1 commit into from
Apr 22, 2020

Conversation

ariasuni
Copy link
Contributor

Disable data reporting and the annoying notification that you can recognize in the screenshot:

Screenshot_20200413_195654

@coveralls
Copy link

coveralls commented Apr 13, 2020

Coverage Status

Coverage remained the same at 100.0% when pulling 153f8bf on ariasuni:disable-datareporting into e0d4c3c on mozilla:master.

@Rob--W
Copy link
Member

Rob--W commented Apr 14, 2020

Could you amend the commit and change its title to adhere to the commitlint format? The build failed due to the following error:

> node ./scripts/travis-pr-title-lint

There is only one commit in this pull request, we are going to check the single commit message...
Failures during changelog linting the pull request:

⧗   input: Disable data reporting and “Choose what I share” notification
✖   subject may not be empty [subject-empty]
✖   type may not be empty [type-empty]

✖   found 2 problems, 0 warnings
ⓘ   Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint

Don't panic! If your travis build is failing here, please take a look at

 - https://github.com/mozilla/web-ext/blob/master/CONTRIBUTING.md#writing-commit-messages

and feel free to ask for help from one of the maintainers in a comment; we are here to help ;-)

@ariasuni
Copy link
Contributor Author

Now it’s good :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants