chore(deps): Upgrade chrome-launcher from 0.15.1 to 1.1.2 #3200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aklinker1
changed the title
chrome-launcher to 1.1.2
aklinker1
commented
Jul 16, 2024
There was a problem hiding this comment.
None of the changes to the default flags seem relevant to extensions so I didn't adjust the filtering, but someone more familiar with browsers might want to double check.
fregante
reviewed
Aug 4, 2024
| @@ -49,7 +49,7 @@ describe('util/extension-runners/chromium', async () => { | |||
| it('uses the expected chrome flags', () => { | |||
| // Flags from chrome-launcher v0.14.0 | |||
| const expectedFlags = [ | |||
| '--disable-features=Translate', | |||
| '--disable-features=Translate,OptimizationHints,MediaRouter,DialMediaRouteProvider,CalculateNativeWinOcclusion,InterestFeedContentSuggestions,CertificateTransparencyComponentUpdater,AutofillServerCommunication,PrivacySandboxSettings4', | |||
There was a problem hiding this comment.
Do any of these cover the new search engines picker? It's quite annoying.
Starting a new profile (web-ext run --target chromium) is basically a whack-a-mole.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #2912, and replaces #3170.