Add attached files to report #54
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Delete button for admins. Fix mozillahispano#30 Added deletion confirmation in delete mention option I forgot to add delete_mention template Module not needed removed. Fixed traslation strings Delete button for admins. Fix mozillahispano#30 Delete button for admins. Fix mozillahispano#30 Fixed traslation strings in index
|
Sorry for my previous two commits. I had them merged on the main django15 branch. From now on, I will start a new branch for each issue. |
| relevant_audience = models.BooleanField() | ||
| update_rate = models.IntegerField(max_length=1, choices=UPDATE_RATE) | ||
| remarks = models.TextField(null=True, blank=True) | ||
| file1 = models.FileField(upload_to='report_files/', blank=True, null=True) | ||
| file2 = models.FileField(upload_to='report_files/', blank=True, null=True) | ||
| file3 = models.FileField(upload_to='report_files/', blank=True, null=True) |
There was a problem hiding this comment.
Lets try to use a different approach here for not to have restrictions in the number of attached files. An option would be a new model for attached files with a reference (FK) to the mentions.
There was a problem hiding this comment.
I wanted to modify models as less as possible. Anyway, noted. I'll do it the other way. You can discard that pull request as I will be starting from scratch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add attached files to report. Fix #26