rust-analyze: only stick with the deps/save-analysis file, instead of all of them. #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This unblocks servo. |
staktrace
approved these changes
Jan 22, 2018
The Rust indexer is about to create stuff under __GENERATED__.
It's easier to figure out mismatches for rls-data, for example.
It's not clear the shell script accounts correctly for whitespace in the paths. That being said it's not clear other scripts do so, and we have control over the paths anyway.
|
@emilio Is there anything from this patch we still want noting that we may want to switch to using LSIF for rust (https://bugzilla.mozilla.org/show_bug.cgi?id=1761287) and that I think I addressed the generated files issues in other patches (#299 and #339 maybe based on blame)? Note that the rust stuff is not super high on my personal priority list right now, but the JS LSIF stuff is (https://bugzilla.mozilla.org/show_bug.cgi?id=1740290), and there's a good chance of there being synergies there. |
|
Yeah, let's close for now. |
This was referenced Aug 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building with crates.io, all the crate dependencies also get save-analysis
dirs.
We probably want to use them, but not quite yet.