Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for bme and reintroduce unique_ptr #26

Merged
merged 6 commits into from
Aug 28, 2023
Merged

Conversation

profawk
Copy link
Contributor

@profawk profawk commented Aug 16, 2023

this pr does the following:
1. adds support for BME280
2. allows leveraging of the safety given by unique_ptr
3. calls the relevant reset only for the active sensor

please talk to me before you do big changes the code.
this is tested with a BME280

@mp-se
Copy link
Owner

mp-se commented Aug 16, 2023

Please revert the changes that you made to the reset logic. This should be valid for all sensors. Reset should do a power off/on for the connected sensor.

Also run the pre commit hooks so the checks passes.

@profawk
Copy link
Contributor Author

profawk commented Aug 18, 2023

I fixed the CI errors and reverted the reset change

@mp-se
Copy link
Owner

mp-se commented Aug 19, 2023

I can see that this uses i2c bus connection and you connected this to the same bus as the displays ?

I will need to do an update to the schema as well to make it clear how to hook up this sensor and it will require a different wiring for the scale base as well.

Have you tested this setup with a long cable (1.5 - 2m) to the scale so its confirmed that it will work when placing the sensor in the base of the scale ?

@mp-se mp-se merged commit d44d61d into mp-se:dev Aug 28, 2023
1 check passed
@mp-se
Copy link
Owner

mp-se commented Aug 29, 2023

I have merged this PR into the dev stream and checked that the sensor can be read. Will do more testing before making a release.

I also added the pressure value that the sensor can provide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants