Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Get marketing cloud id directly from SDK #19

Merged
merged 3 commits into from
Nov 2, 2022
Merged

fix: Get marketing cloud id directly from SDK #19

merged 3 commits into from
Nov 2, 2022

Conversation

einsteinx2
Copy link
Contributor

Summary

No longer try to call the Adobe API to get the user's ID, just ask the Adobe SDK instead when it exists (when using Adobe Media SDK)

Testing Plan

  • Tested locally, confirmed with Charles proxy and logging

Reference Issue

BrandonStalnaker
BrandonStalnaker approved these changes Nov 2, 2022
View reviewed changes
Copy link
Contributor

@BrandonStalnaker BrandonStalnaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We went over this together on Zoom and everything looks good 👍

peterjenkins
peterjenkins approved these changes Nov 2, 2022
View reviewed changes
Copy link
Contributor

@peterjenkins peterjenkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@einsteinx2 einsteinx2 merged commit 506d127 into development Nov 2, 2022
@einsteinx2 einsteinx2 deleted the fix/SQDSDKS-4728-adobe-identity-from-sdk branch November 2, 2022 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrandonStalnaker BrandonStalnaker BrandonStalnaker approved these changes

@peterjenkins peterjenkins peterjenkins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@einsteinx2 @peterjenkins @BrandonStalnaker